Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BufferedReader.get_message docstring #1397

Merged

Conversation

barbacbd
Copy link
Contributor

** Docstring now states that the get_message method utilizes a FIFO ordering for grabbing messages from the queue.

#1207

Copy link
Contributor

@nertpinx nertpinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just change the one mentioned thing, otherwise it looks fine to me.

can/listener.py Outdated Show resolved Hide resolved
can/listener.py Outdated Show resolved Hide resolved
can/listener.py Outdated Show resolved Hide resolved
** Docstring now states that the `get_message` method utilizes a FIFO
ordering for grabbing messages from the queue.
@barbacbd barbacbd force-pushed the update_get_message_docstring branch from 34f68ea to ed6bf9f Compare October 3, 2022 11:37
@barbacbd barbacbd requested review from zariiii9003 and removed request for nertpinx October 3, 2022 11:37
Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zariiii9003 zariiii9003 merged commit 23b6b19 into hardbyte:develop Oct 3, 2022
j-c-cook added a commit to j-c-cook/python-can that referenced this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants