PCAN: Fix Detection of Library on Windows on ARM #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit detection of the PCAN DLL would fail on Windows on ARM, regardless if you used the native Python version, or the x64 version of Python. After this fix detection should work properly as long as the PCAN library for your version of Python is listed first in the `PATH` variable. The default: 1. `C:\Program Files\PEAK-System\PEAK-Drivers 4\APIs\ARM64\` before 2. `C:\Program Files\PEAK-System\PEAK-Drivers 4\APIs\x64\` should work if you use the (native) ARM version of Python. If you reorder these paths, then loading the library works in the x64 version of Python. This commit closes #1461.
felixdivo
approved these changes
Dec 21, 2022
|
Looks like the test suite does not like the Window emoji ( At least that is what I would assume from the output of the Python code: print("\U0001fa9f")Should I reopen the pull request from a different different branch (that only contains ASCII characters)? |
|
I'd suggest just merging this. @hardbyte? |
|
Where is the emoji coming from? pip? Edit: Your branch name... i see 😄 |
|
I merged it and now the CI fails, oops. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit detection of the PCAN DLL would fail on Windows on ARM, regardless if you used the native Python version, or the x64 version of Python. After this fix detection should work properly as long as the PCAN library for your version of Python is listed first in the
PATHvariable. The default:C:\Program Files\PEAK-System\PEAK-Drivers 4\APIs\ARM64\beforeC:\Program Files\PEAK-System\PEAK-Drivers 4\APIs\x64\should work if you use the (native) ARM version of Python. If you reorder these paths, then loading the library works in the x64 version of Python.
I tested the fix on the native version of Python
3.11and the x64 version of Python3.10in Window on ARM, where everything seemed to work as expected. For more information, please take a look at issue #1461.