Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for TRC files #1530

Merged
merged 5 commits into from Mar 30, 2023
Merged

Improve support for TRC files #1530

merged 5 commits into from Mar 30, 2023

Conversation

twam
Copy link
Contributor

@twam twam commented Mar 3, 2023

  • Add support for Version 2.0
  • Add support for $STARTTIME in Version 1.1 and Version 2.1
  • Add support for $COLUMNS in Version 2.1

@twam twam force-pushed the feature/support-trc-2.0 branch 2 times, most recently from 01605ef to 5c3f018 Compare March 3, 2023 09:40
@twam
Improve support for TRC files
fb8146b 
* Add support for Version 2.0
* Add support for $STARTTIME in Version 1.1 and Version 2.1
* Add support for $COLUMNS in Version 2.1
@twam
Copy link
Contributor Author

twam commented Mar 7, 2023

Rebased to latest develop branch with updated linters/black and applied required changes.

@zariiii9003
Copy link
Collaborator

@pkess could you take a look?

@pkess
Copy link
Contributor

pkess commented Mar 9, 2023

Hello @zariiii9003, hello @twam
Thank you for your request for a review from me. I had a deeper look into this now and the changes are looking great. Thank you for this contribution.

It might be nice to add some more tests and test data in the future but this would improve this package very much just as it is right now

zariiii9003
zariiii9003 reviewed Mar 14, 2023
View reviewed changes
can/io/trc.py Outdated Show resolved Hide resolved
@zariiii9003 zariiii9003 merged commit 740c50c into hardbyte:develop Mar 30, 2023
30 of 31 checks passed
@zariiii9003
Copy link
Collaborator

Thanks!

@TedRio TedRio mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zariiii9003 zariiii9003 zariiii9003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@twam @zariiii9003 @pkess