Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trc 1.3 support #1753

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Add trc 1.3 support #1753

merged 1 commit into from
Mar 12, 2024

Conversation

1atabey1
Copy link
Contributor

Adds support for .trc log files as generated by e.g. PCAN Explorer v5

After implementing the change I noticed that there is already two open PRs implementing the same (:
-> #1638 and #1727

However this might be easier to merge since build passes (when i run it locally) and a corresponding test has been added

@1atabey1
Copy link
Contributor Author

hmm not really sure why tests are failing for python 3.11 (windows) only, maybe someone can trigger a re-run?

Copy link
Collaborator

@zariiii9003 zariiii9003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test! Looks good.

@zariiii9003 zariiii9003 added the file-io about reading & writing to files label Mar 12, 2024
@zariiii9003 zariiii9003 merged commit ffb14a3 into hardbyte:main Mar 12, 2024
28 of 29 checks passed
@1atabey1 1atabey1 deleted the add-trc1_3-support branch June 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-io about reading & writing to files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants