Added extra info for Kvaser dongles #1763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Kvaser auto-detection function to return additional info regarding the dongles found, such as Serial Number, Name and Dongle Channel number. In this way it's possible to discern between different physical dongles connected to the PC and if they are Virtual Channels or not.
hardbyte
approved these changes
Apr 8, 2024
can/interfaces/kvaser/canlib.py
Outdated
| return f"{name_decoded}, S/N {serial.value} (#{number.value + 1})" | ||
|
|
||
| return { | ||
| "name": name.value.decode("ascii", errors="replace"), |
There was a problem hiding this comment.
Suggested change
| "name": name.value.decode("ascii", errors="replace"), | |
| "device_name": name.value.decode("ascii", errors="replace"), |
Changed "name" into "device_name" as suggested by python-can owner.
zariiii9003
reviewed
Apr 16, 2024
can/interfaces/kvaser/canlib.py
Outdated
| @@ -471,6 +471,7 @@ def __init__( | |||
| log.info("Found %d available channels", num_channels) | |||
| for idx in range(num_channels): | |||
| channel_info = get_channel_info(idx) | |||
| channel_info = f"{channel_info["device_name"]}, S/N {channel_info["serial"]} (#{channel_info["dongle channel"]})" | |||
There was a problem hiding this comment.
Double quotes inside of double quotes is a syntax error in older Python versions.
There was a problem hiding this comment.
Sorry, I just started using Python last year with the latest version and I'm unaware of these retrocompatibility issues. Can I change it using single quotes for the f-string but maitain the dict indexing inside it with double quotes? Thanks in advance
Changed " with ' for retrocompatibility problem with older Python versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed Kvaser auto-detection function to return additional info regarding the found dongles, such as Serial Number, Name and Dongle Channel number.
In this way it's possible to discern between different physical dongles connected to the PC and if they are Virtual Channels or not.