Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSTS redirection warning false positive when redirecting to parent host with includeSubDomains #42

Closed
ivanr opened this issue Oct 8, 2018 · 2 comments
Assignees
Labels

Comments

@ivanr
Copy link
Contributor

ivanr commented Oct 8, 2018

We currently have a rule that checks if the redirections are properly implemented and activate HSTS. The rule is that a request to plaintext www.example.com must be redirected to encrypted www.example.com before it goes anywhere else. However, this rule creates false positives in the case when there is a redirection to the parent host with includeSubDomains enabled.

@ivanr ivanr added the bug label Oct 8, 2018
@ivanr ivanr self-assigned this Oct 8, 2018
@ivanr
Copy link
Contributor Author

ivanr commented Mar 21, 2019

Fixed as of a couple weeks ago.

@ivanr ivanr closed this as completed Mar 21, 2019
@adrelanos
Copy link

Regression? Bug happening again?

https://www.hardenize.com/report/whonix.org/1670890391#www_hsts

Hardenize notices: includeSubDomains=true

Policy preloaded
Excellent. This host is covered by a preloaded HSTS policy.
Preloaded host: whonix.org; includeSubDomains=true

Therefore it seems the following error is a false-positive:

Redirection from HTTP to HTTPS not to the same host
When HSTS is used, the plaintext port should redirect to the HTTPS variant of the same hostname. This approach ensures that HSTS is enabled on that hostname, even if later the client is sent elsewhere. A redirection to another host is only safe if it is for a parent host that has HSTS with includeSubDomains enabled, but that's not the case here.
Starting point: http://whonix.org

Current redirection: https://www.whonix.org/

Expected redirection: https://whonix.org

Could you re-open please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants