Pip pakage #36
Merged
Pip pakage #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chg; dev: setup.py config
|
update here https://pypi.python.org/pypi/google-images-download/1.0.1 if this pr accepted the readme should be changed. also if possible convert it directly to rst, so no conversion is needed when upload it to pypi |
|
[pasting it her instead] @rachmadaniHaryono do let me know if there are any changes to be made post merge... :) EDIT: just wanted to ask why is the BSD license attached to the PIP package if the original repo is under MIT? I do not understand how/if they differ in terms of rights, but just pointing out the difference. |
It should be changed on setup.py. I can create pr for that along some edit to Readme file.
This can be made after this pr merged |
|
thanks @rachmadaniHaryono . Merged the PR. |
rachmadaniHaryono
pushed a commit
to rachmadaniHaryono/gbooru-images-download
that referenced
this pull request
Feb 27, 2018
Set default encoding as UTF-8. It is for adjust to Japanese,Korea and Chinese. This update can save as each keyword name folder. Bug fix : when make folder ,script has braked bug fix:code breaks on multiple keywords timeout to not wait infinitely to download Resolving SSL certificate failed error Python 3 compatibility and other bug resolves Doc update for SSL errors files downloaded with correct extension and python 3 support command line access to the script and bug fixes Added support for filtering on color append color to output directory name doc update for new param Identation fixed Update google-images-download.py removing redundant import of urllib2 as it is deprecated in python3 added exception for ssl.CertificateError Update README.md Adding the ability to download from specific google image URL (hardikvasa#32) * adding argument for single image download via URL single image download using url Update README.md minor changes to the doc Enable non-English search input (hardikvasa#31) * Enable non-English search input * Add dependencies for non-English search term in Python2 * Resolve conflict and tested on both Python3 and Python2 * Remove unnecessary line Enable non-English search input (hardikvasa#31) multiple feature inclusions and bug resolves new spefications and search patterns removed .gitignore Update README.md minor update to the doc Update README.md minor update to the doc minor doc modifications added new image search filters and doc changes updated the licence year added suffix keyword and lots of small improvements resolved windows directory bug as per issue hardikvasa#34 fix UnicodeEncodeError in bulk_download function Pip pakage (hardikvasa#36) * boilerplate setup * google-images-download.py -> google-images-download/google-images-download.py * console script * requirements final * description syntaxError fixed * extra gitignore folder added * pakage entry point error fixed * New installation and uses added * unverified email errror fixed * unverified email errror fixed * chg; dev: setup.py config added URL print support, license change and few editions doc update doc update Feature/update pypi (hardikvasa#39) (hardikvasa#40) * chg: doc: license on setup.py * chg: doc: rename README.md to README.rst * chg: doc: syntax from markdown to rst * chg: doc: command on readme * chg: doc: re add table * chg: doc: remove duplicate example * chg: doc: remove readme convertion rst is already default readme filetype * chg: doc: update table to latest upstream commit * chg: doc: update classifiers to latest upstream commit * chg: dev: update print_urls description fix newlines on table (hardikvasa#41) * chg: doc: rename README.md to README.rst * chg: doc: syntax from markdown to rst * chg: doc: command on readme * chg: doc: re add table * chg: doc: remove duplicate example * chg: doc: update table to latest upstream commit * chg: dev: update print_urls description * chg: dev: update contribute section to latest upstream commit * fix: doc: newline on table * fix: doc: line on table fix: dev: ImportError on python2
rachmadaniHaryono
pushed a commit
to rachmadaniHaryono/gbooru-images-download
that referenced
this pull request
Feb 27, 2018
Set default encoding as UTF-8. It is for adjust to Japanese,Korea and Chinese. This update can save as each keyword name folder. Bug fix : when make folder ,script has braked bug fix:code breaks on multiple keywords timeout to not wait infinitely to download Resolving SSL certificate failed error Python 3 compatibility and other bug resolves Doc update for SSL errors files downloaded with correct extension and python 3 support command line access to the script and bug fixes Added support for filtering on color append color to output directory name doc update for new param Identation fixed Update google-images-download.py removing redundant import of urllib2 as it is deprecated in python3 added exception for ssl.CertificateError Update README.md Adding the ability to download from specific google image URL (hardikvasa#32) * adding argument for single image download via URL single image download using url Update README.md minor changes to the doc Enable non-English search input (hardikvasa#31) * Enable non-English search input * Add dependencies for non-English search term in Python2 * Resolve conflict and tested on both Python3 and Python2 * Remove unnecessary line Enable non-English search input (hardikvasa#31) multiple feature inclusions and bug resolves new spefications and search patterns removed .gitignore Update README.md minor update to the doc Update README.md minor update to the doc minor doc modifications added new image search filters and doc changes updated the licence year added suffix keyword and lots of small improvements resolved windows directory bug as per issue hardikvasa#34 fix UnicodeEncodeError in bulk_download function Pip pakage (hardikvasa#36) * boilerplate setup * google-images-download.py -> google-images-download/google-images-download.py * console script * requirements final * description syntaxError fixed * extra gitignore folder added * pakage entry point error fixed * New installation and uses added * unverified email errror fixed * unverified email errror fixed * chg; dev: setup.py config added URL print support, license change and few editions doc update doc update Feature/update pypi (hardikvasa#39) (hardikvasa#40) * chg: doc: license on setup.py * chg: doc: rename README.md to README.rst * chg: doc: syntax from markdown to rst * chg: doc: command on readme * chg: doc: re add table * chg: doc: remove duplicate example * chg: doc: remove readme convertion rst is already default readme filetype * chg: doc: update table to latest upstream commit * chg: doc: update classifiers to latest upstream commit * chg: dev: update print_urls description fix newlines on table (hardikvasa#41) * chg: doc: rename README.md to README.rst * chg: doc: syntax from markdown to rst * chg: doc: command on readme * chg: doc: re add table * chg: doc: remove duplicate example * chg: doc: update table to latest upstream commit * chg: dev: update print_urls description * chg: dev: update contribute section to latest upstream commit * fix: doc: newline on table * fix: doc: line on table fix: dev: ImportError on python2
SecorD0
referenced
this pull request
in SecorD0/google-images-download
Dec 2, 2022
* boilerplate setup * google-images-download.py -> google-images-download/google-images-download.py * console script * requirements final * description syntaxError fixed * extra gitignore folder added * pakage entry point error fixed * New installation and uses added * unverified email errror fixed * unverified email errror fixed * chg; dev: setup.py config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a pip pakage named google_images_download
https://pypi.python.org/pypi/google-images-download