Skip to content

Commit

Permalink
CIFS: Fix wrong directory attributes after rename
Browse files Browse the repository at this point in the history
commit b46799a upstream.

When we requests rename we also need to update attributes
of both source and target parent directories. Not doing it
causes generic/309 xfstest to fail on SMB2 mounts. Fix this
by marking these directories for force revalidating.

Signed-off-by: Pavel Shilovsky <pshilovsky@samba.org>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Zefan Li <lizefan@huawei.com>
  • Loading branch information
piastry authored and lizf-os committed Sep 25, 2014
1 parent a0e5b9d commit d06e4b0
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions fs/cifs/inode.c
Expand Up @@ -1653,6 +1653,12 @@ int cifs_rename(struct inode *source_dir, struct dentry *source_dentry,
target_dentry, toName);
}

/* force revalidate to go get info when needed */
CIFS_I(source_dir)->time = CIFS_I(target_dir)->time = 0;

source_dir->i_ctime = source_dir->i_mtime = target_dir->i_ctime =
target_dir->i_mtime = current_fs_time(source_dir->i_sb);

cifs_rename_exit:
kfree(info_buf_source);
kfree(fromName);
Expand Down

0 comments on commit d06e4b0

Please sign in to comment.