Reorganize settings screen #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename Setting to SettingScreen - add Settings class - move and change wifi_conn_ok and wifi_credentials_state to Settings - move current and voltage settings to Settings - move voltage and current settings from String to uint16_t - change current and voltage saving data type from String to uint16_t - change current_limit counting
- make screens separate objects - fix voltage screen selection jumping - fix log interval on shutdown sometimes turning off
- update platform from espressif32 6.1.0 to 6.2.0 - remove outdated ArduinoNVS library - switched to officially supported Preferences library - load screen fonts via single method to prevent multiple large inclusions - remove ArduinoNVS from submodules
- cleanup of redundant code - added code check configuration to platformio.ini - corrections of some problems found by cppcheck (mainly initializations) - logging fix - add NVS clearing on first run after update
cedel1
commented
May 13, 2023
smartpower3/screens/screen.cpp
Outdated
Comment on lines
3
to
4
| #include "fonts/ChewyRegular24.h" | ||
| #include "fonts/ChewyRegular32.h" |
Comment on lines
469
to
471
| com_serial_baud->setTextColor(color, BG_COLOR); | ||
| drawSerialBaud(this->serial_baud); | ||
| com_serial_baud->select(); |
There was a problem hiding this comment.
Unused color change of font when selected slows down screen redraw quite a lot - the selection movement then starts to behave erratically.
| } | ||
|
|
||
| void SettingScreen::selectSerialLogging(uint16_t color) |
There was a problem hiding this comment.
This was the method that drew the frame around both serial baud and logging interval.
- remove group selection - warning color when interval value forcibly changed - use one font only on settings - change alignment and spacing to be more consistent and readable - remove unused font color change when selecting to improve graphic performance
cedel1
force-pushed
the
reorganize_settings_screen
branch
from
89c0803
to
c124e11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #33 .