Don't prematurely disable the CSS domain (#757)

hardkoded · Nov 14, 2018 · 0f2f632 · 0f2f632
1 parent 5986642
commit 0f2f632
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/PuppeteerSharp.Tests/CSSCoverageTests/CSSCoverageTests.cs b/lib/PuppeteerSharp.Tests/CSSCoverageTests/CSSCoverageTests.cs
@@ -130,5 +130,22 @@ public async Task ShouldIgnoreInjectedStylesheets()
             var coverage = await Page.Coverage.StopCSSCoverageAsync();
             Assert.Empty(coverage);
         }
+
+        [Fact]
+        public async Task ShouldWorkWithArRecentlyLoadedStylesheet()
+        {
+            await Page.Coverage.StartCSSCoverageAsync();
+            await Page.EvaluateFunctionAsync(@"async url => {
+                document.body.textContent = 'hello, world';
+
+                const link = document.createElement('link');
+                link.rel = 'stylesheet';
+                link.href = url;
+                document.head.appendChild(link);
+                await new Promise(x => link.onload = x);
+            }", TestConstants.ServerUrl + "/csscoverage/stylesheet1.css");
+            var coverage = await Page.Coverage.StopCSSCoverageAsync();
+            Assert.Single(coverage);
+        }
     }
 }
diff --git a/lib/PuppeteerSharp/PageCoverage/CSSCoverage.cs b/lib/PuppeteerSharp/PageCoverage/CSSCoverage.cs
@@ -57,16 +57,15 @@ internal async Task<CoverageEntry[]> StopAsync()
             }
             _enabled = false;
 
-            var ruleTrackingResponseTask = _client.SendAsync<CSSStopRuleUsageTrackingResponse>("CSS.stopRuleUsageTracking");
+            var trackingResponse = await _client.SendAsync<CSSStopRuleUsageTrackingResponse>("CSS.stopRuleUsageTracking").ConfigureAwait(false);
             await Task.WhenAll(
-                ruleTrackingResponseTask,
                 _client.SendAsync("CSS.disable"),
                 _client.SendAsync("DOM.disable")
             ).ConfigureAwait(false);
             _client.MessageReceived -= client_MessageReceived;
 
             var styleSheetIdToCoverage = new Dictionary<string, List<CoverageResponseRange>>();
-            foreach (var entry in ruleTrackingResponseTask.Result.RuleUsage)
+            foreach (var entry in trackingResponse.RuleUsage)
             {
                 styleSheetIdToCoverage.TryGetValue(entry.StyleSheetId, out var ranges);
                 if (ranges == null)