Skip to content

Commit

Permalink
Remove unused members (#2191)
Browse files Browse the repository at this point in the history
* Remove unused NavigationURL

Introduced in fb7c1a4
Unused since 622f1f8

* Removed unused TargetsMap

Looks like a leftover from #2051
  • Loading branch information
jnyrup committed Apr 24, 2023
1 parent 4e03bfc commit 28f0354
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
6 changes: 2 additions & 4 deletions lib/PuppeteerSharp/ChromeTargetManager.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Linq;
Expand Down Expand Up @@ -72,8 +72,6 @@ internal class ChromeTargetManager : ITargetManager

public event EventHandler<TargetChangedArgs> TargetDiscovered;

internal IDictionary<string, Target> TargetsMap { get; }

public ConcurrentDictionary<string, Target> GetAvailableTargets() => _attachedTargetsByTargetId;

public async Task InitializeAsync()
Expand Down Expand Up @@ -350,4 +348,4 @@ private void OnDetachedFromTarget(object sender, TargetDetachedFromTargetRespons
TargetGone?.Invoke(this, new TargetChangedArgs { Target = target });
}
}
}
}
3 changes: 0 additions & 3 deletions lib/PuppeteerSharp/Frame.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ internal Frame(FrameManager frameManager, string frameId, string parentFrameId,

internal List<string> LifecycleEvents { get; }

internal string NavigationURL { get; private set; }

internal IsolatedWorld MainWorld { get; private set; }

internal IsolatedWorld PuppeteerWorld { get; private set; }
Expand Down Expand Up @@ -343,7 +341,6 @@ internal void OnLifecycleEvent(string loaderId, string name)
internal void Navigated(FramePayload framePayload)
{
Name = framePayload.Name ?? string.Empty;
NavigationURL = framePayload.Url + framePayload.UrlFragment;
Url = framePayload.Url + framePayload.UrlFragment;
}

Expand Down

0 comments on commit 28f0354

Please sign in to comment.