Remove extra GetDocument function

hardkoded · Apr 15, 2023 · 9e58294 · 9e58294
1 parent 296cb79
commit 9e58294
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 19 deletions.
diff --git a/lib/PuppeteerSharp.Tests/ClickTests/ClickTests.cs b/lib/PuppeteerSharp.Tests/ClickTests/ClickTests.cs
@@ -77,7 +77,7 @@ public async Task ShouldGracefullyFailWhenPageCloses()
                 newPage.Mouse.ClickAsync(1, 2));
         }
 
-        [PuppeteerTest("click.spec.ts", "Page.click", "should click the button after navigation ")]
+        [PuppeteerTest("click.spec.ts", "Page.click", "should click the button after navigation")]
         [PuppeteerFact]
         public async Task ShouldClickTheButtonAfterNavigation()
         {

diff --git a/lib/PuppeteerSharp/IsolatedWorld.cs b/lib/PuppeteerSharp/IsolatedWorld.cs
@@ -32,7 +32,6 @@ internal class IsolatedWorld
         private readonly List<string> _ctxBindings = new();
         private bool _detached;
         private TaskCompletionSource<ExecutionContext> _contextResolveTaskWrapper = new(TaskCreationOptions.RunContinuationsAsynchronously);
-        private TaskCompletionSource<IElementHandle> _documentCompletionSource;
         private Task _settingUpBinding;
         private Task<ElementHandle> _documentTask;
 
@@ -215,25 +214,25 @@ internal async Task<JToken> EvaluateFunctionAsync(string script, params object[]
 
         internal async Task<IElementHandle> QuerySelectorAsync(string selector)
         {
-            var document = await GetDocument().ConfigureAwait(false);
+            var document = await GetDocumentAsync().ConfigureAwait(false);
             return await document.QuerySelectorAsync(selector).ConfigureAwait(false);
         }
 
         internal async Task<IJSHandle> QuerySelectorAllHandleAsync(string selector)
         {
-            var document = await GetDocument().ConfigureAwait(false);
+            var document = await GetDocumentAsync().ConfigureAwait(false);
             return await document.QuerySelectorAllHandleAsync(selector).ConfigureAwait(false);
         }
 
         internal async Task<IElementHandle[]> QuerySelectorAllAsync(string selector)
         {
-            var document = await GetDocument().ConfigureAwait(false);
+            var document = await GetDocumentAsync().ConfigureAwait(false);
             return await document.QuerySelectorAllAsync(selector).ConfigureAwait(false);
         }
 
         internal async Task<IElementHandle[]> XPathAsync(string expression)
         {
-            var document = await GetDocument().ConfigureAwait(false);
+            var document = await GetDocumentAsync().ConfigureAwait(false);
             return await document.XPathAsync(expression).ConfigureAwait(false);
         }
 
@@ -566,19 +565,6 @@ private async Task OnBindingCalled(BindingCalledResponse e)
 
         private string GetBindingIdentifier(string name, int contextId) => $"{name}_{contextId}";
 
-        private async Task<IElementHandle> GetDocument()
-        {
-            if (_documentCompletionSource == null)
-            {
-                _documentCompletionSource = new TaskCompletionSource<IElementHandle>(TaskCreationOptions.RunContinuationsAsynchronously);
-                var context = await GetExecutionContextAsync().ConfigureAwait(false);
-                var document = await context.EvaluateExpressionHandleAsync("document").ConfigureAwait(false);
-                _documentCompletionSource.TrySetResult(document as IElementHandle);
-            }
-
-            return await _documentCompletionSource.Task.ConfigureAwait(false);
-        }
-
         private string MakePredicateString(string predicate, string predicateQueryHandler)
         {
             var checkWaitForOptions = @"function checkWaitForOptions(