Skip to content

Commit

Permalink
Roll to Chrome 117.0.5938.62 (r1181205) (#2327)
Browse files Browse the repository at this point in the history
  • Loading branch information
kblok committed Sep 22, 2023
1 parent 7456302 commit a2a0f9c
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 36 deletions.
57 changes: 23 additions & 34 deletions lib/PuppeteerSharp.Tests/AccessibilityTests/AccessibilityTests.cs
Expand Up @@ -4,11 +4,11 @@
using PuppeteerSharp.Nunit;
using NUnit.Framework;

namespace PuppeteerSharp.Tests.AccesibilityTests
namespace PuppeteerSharp.Tests.AccessibilityTests
{
public class AccesibilityTests : PuppeteerPageBaseTest
public class AccessibilityTests : PuppeteerPageBaseTest
{
public AccesibilityTests(): base()
public AccessibilityTests() : base()
{
}

Expand Down Expand Up @@ -43,66 +43,62 @@ public async Task ShouldWork()
Name = "Accessibility Test",
Children = new SerializedAXNode[]
{
new SerializedAXNode
{
new() {
Role = "StaticText",
Name = "Hello World"
},
new SerializedAXNode
{
new() {
Role = "heading",
Name = "Inputs",
Level = 1
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "Empty input",
Focused = true
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "readonly input",
Readonly = true
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "disabled input",
Disabled= true
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "Input with whitespace",
Value= " "
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "",
Value= "value only"
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "placeholder",
Value= "and a value"
},
new SerializedAXNode{
new (){
Role = "textbox",
Name = "placeholder",
Value= "and a value",
Description= "This is a description!"},
new SerializedAXNode{
new (){
Role= "combobox",
Name= "",
Value= "First Option",
HasPopup = "menu",
Children= new SerializedAXNode[]{
new SerializedAXNode
{
new() {
Role = "menuitem",
Name = "First Option",
Selected= true
},
new SerializedAXNode
{
new() {
Role = "menuitem",
Name = "Second Option"
}
Expand Down Expand Up @@ -132,14 +128,12 @@ public async Task ShouldReportUninterestingNodes()
Multiline = true,
Children = new SerializedAXNode[]
{
new SerializedAXNode
{
new() {
Role = "generic",
Name = "",
Children = new SerializedAXNode[]
{
new SerializedAXNode
{
new() {
Role = "StaticText",
Name = "hi"
}
Expand Down Expand Up @@ -266,14 +260,12 @@ public async Task ShouldNotReportTextNodesInsideControls()
Name = "",
Children = new SerializedAXNode[]
{
new SerializedAXNode
{
new() {
Role = "tab",
Name = "Tab1",
Selected = true
},
new SerializedAXNode
{
new() {
Role = "tab",
Name = "Tab2"
}
Expand All @@ -298,14 +290,12 @@ public async Task RichTextEditableFieldsShouldHaveChildren()
Value = "Edit this image: ",
Children = new SerializedAXNode[]
{
new SerializedAXNode
{
new() {
Role = "StaticText",
Name = "Edit this image: "
},
new SerializedAXNode
{
Role = "img",
new() {
Role = "image",
Name = "my fake image"
}
}
Expand All @@ -330,8 +320,7 @@ public async Task RichTextEditableFieldsWithRoleShouldHaveChildren()
Multiline = true,
Children = new SerializedAXNode[]
{
new SerializedAXNode
{
new() {
Role = "StaticText",
Name = "Edit this image: "
},
Expand Down
Expand Up @@ -4,7 +4,7 @@
using PuppeteerSharp.Nunit;
using NUnit.Framework;

namespace PuppeteerSharp.Tests.AccesibilityTests
namespace PuppeteerSharp.Tests.AccessibilityTests
{
public class RootOptionTests : PuppeteerPageBaseTest
{
Expand Down
2 changes: 1 addition & 1 deletion lib/PuppeteerSharp/BrowserData/Chrome.cs
Expand Up @@ -13,7 +13,7 @@ public static class Chrome
/// <summary>
/// Default chrome build.
/// </summary>
public static string DefaultBuildId => "115.0.5790.102";
public static string DefaultBuildId => "117.0.5938.62";

internal static async Task<string> ResolveBuildIdAsync(ChromeReleaseChannel channel)
=> (await GetLastKnownGoodReleaseForChannel(channel).ConfigureAwait(false)).Version;
Expand Down
1 change: 1 addition & 0 deletions lib/PuppeteerSharp/PageAccessibility/AXNode.cs
Expand Up @@ -99,6 +99,7 @@ internal bool IsLeafNode()
case "doc-cover":
case "graphics-symbol":
case "img":
case "image":
case "Meter":
case "scrollbar":
case "slider":
Expand Down

0 comments on commit a2a0f9c

Please sign in to comment.