Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use GTK theme buttons instead of custom buttons #50

Closed
ghost opened this issue May 18, 2018 · 7 comments
Closed

[Feature Request] Use GTK theme buttons instead of custom buttons #50

ghost opened this issue May 18, 2018 · 7 comments
Labels

Comments

@ghost
Copy link

ghost commented May 18, 2018

I create a working extension here, just for test it:
https://github.com/lestcape/metacity-buttons

I open also a question in stackoverflow related with that, to find a better implementation if some one help:
https://stackoverflow.com/questions/50313744/how-to-darwing-the-window-buttons-from-a-gtk-context-in-gjs

Whatever you want to know about it, just ask.

@lapega
Copy link

lapega commented Jun 7, 2018

Your github site is down. Can you post another link? I'm really interested in use the current theme buttons with this extension.

@jonian
Copy link
Member

jonian commented Jun 9, 2018

@lapega https://gitlab.com/lestcape/metacity-buttons

@vccortez
Copy link

this would make it work with yaru/communitheme, I think it's a great idea

@jonian
Copy link
Member

jonian commented Aug 24, 2018

@vekat Right now it is easier and less complicated to add the yaru buttons theme, than to implement the metacity-buttons extension.

In the future I'm planning to implement this, since it is a better solution so you can use a custom theme or inherit from the gtk theme.

@jonian jonian added the feature label Aug 24, 2018
@jonian jonian changed the title Use a theme buttons instead of custtoms buttons. Use GTK theme buttons instead of custom buttons Aug 24, 2018
@jonian jonian changed the title Use GTK theme buttons instead of custom buttons [Feature Request] Use GTK theme buttons instead of custom buttons Aug 24, 2018
@lestcape
Copy link

Well, i remove all my gnome repositories from all places. In case anyone have interest, this solution use the same idea, but instead of Clutter, this example is with a Gtk: https://gitlab.gnome.org/GNOME/gjs/issues/167

@jonian
Copy link
Member

jonian commented Oct 23, 2018

@lestcape Thanks. I will add this feature in an upcoming version.

@lestcape
Copy link

I hope the problem of Gjs can also be resolved to not need to instantiate a gtk components just for nothing, but in the meantime, it should work using the gtk instances.

In the future I'm planning to implement this, since it is a better solution so you can use a custom theme or inherit from the gtk theme.

Yes is nice in that way, because if some theme fail for some reason you can load the custom version. Also i think that could be possible extract the buttons for an specific installed Gtk theme, not matter if is the current applied theme or not. So, users could change between the custom extension themes, all real installed Gtk themes and the current applied Gtk theme. Of course. it will need something to scan for current installed themes. In cinnamon, this python function load the available themes: https://github.com/linuxmint/Cinnamon/blob/master/files/usr/share/cinnamon/cinnamon-settings/modules/cs_themes.py#L268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants