Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling #15

Open
harens opened this issue Nov 29, 2020 · 1 comment
Open

Error handling #15

harens opened this issue Nov 29, 2020 · 1 comment
Labels
codebase Issues relating to the source code good first issue Good for newcomers

Comments

@harens
Copy link
Owner

harens commented Nov 29, 2020

At the moment, there is very little error handling and defensive programming.

Small things such as detecting if there are invalid characters or whether the size is wrong (and then throwing an error) can help to improve the user experience.

This should be quite straight forward to do, and so this should be a good task for any new contributors!
@harens harens added good first issue Good for newcomers codebase Issues relating to the source code labels Nov 29, 2020
@harens harens mentioned this issue Dec 3, 2020
Open
@harens
Copy link
Owner Author

harens commented May 8, 2021

This should be fixed thanks to @beartype in beartype/beartype#32.

It would add our first runtime dependency, but I think in this scenario it's definitely worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codebase Issues relating to the source code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harens