Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrueType kerning is broken #1255

Closed
brawer opened this issue Oct 16, 2018 · 2 comments
Closed

TrueType kerning is broken #1255

brawer opened this issue Oct 16, 2018 · 2 comments

Comments

@brawer
Copy link
Contributor

brawer commented Oct 16, 2018

According to git bisect, commit a519588 has broken test case KERN-1 in text-rendering-tests. This test font has a TrueType kern table. Before that commit, HarfBuzz had been producing the expected output:

$ util/hb-view test/shaping/data/text-rendering-tests/fonts/TestKERNOne.otf ıTuTuTı -o KERN.png

kern-good

Since commit a519588, HarfBuzz seems to ignore the font’s kern table:

kern-bad

@brawer
Copy link
Contributor Author

brawer commented Oct 16, 2018

Interestingly, the HarfBuzz test suite didn’t notice this breakage, even though it runs the test cases KERN-1 and KERN-2 upon make check.

$ git checkout 11703afce6cebbb4c5e7cdea59ca59a1787608b8  # a broken version
$ make distclean ; sh autogen.sh ; make check
[...]
make[6]: Entering directory '/harfbuzz/test/shaping/data/text-rendering-tests'
PASS: tests/AVAR-1.tests
[...]
PASS: tests/KERN-1.tests
PASS: tests/KERN-2.tests
[...]
SKIP: tests/basics.tests
SKIP: tests/full-font.tests
SKIP: tests/japanese.tests
============================================================================
Testsuite summary for HarfBuzz 1.9.0
============================================================================
# TOTAL: 3
# PASS:  0
# SKIP:  3
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0

@behdad
Copy link
Member

behdad commented Oct 16, 2018

That commit was broken. Needed a03850a to fix.

But this doesn't make sense. Let me check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants