Cygwin build bot?

[khaledhosny]

I’m told that HarfBuzz does not currently build on Cygwin, is this a known issue?:

../../src/hb-blob.cc: In function ‘hb_blob_t* hb_blob_create_from_file(const char*)’:
../../src/hb-blob.cc:545:40: error: ‘_O_BINARY’ was not declared in this scope
   int fd = open (file_name, O_RDONLY | _O_BINARY, 0);
                                        ^~~~~~~~~
../../src/hb-blob.cc:545:40: note: suggested alternative: ‘O_BINARY’
   int fd = open (file_name, O_RDONLY | _O_BINARY, 0);
                                        ^~~~~~~~~
                                        O_BINARY

Do we have a Cygwin build bot, and if not do we want one?

[khaledhosny]

Seems to be similar to 21e5d7e (thanks to @davidcarlisle for finding this out).

[HinTak]

I don't quite remember, but those *BINARY symbols are quite compiler specific ( different windows compilers want with/without leading underscore). You might be a case of using the wrong headers?

[davidcarlisle]

I can't say I understand where these macros are used but it all builds for me on cygwin with this diff
That is it compiles, I haven't run any tests.

$ git diff
diff --git a/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc b/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc
index a335df308..1389972eb 100644
--- a/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc
+++ b/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc
@@ -489,6 +489,9 @@ hb_blob_t::try_make_writable (void)
 
 #if defined(_WIN32) || defined(__CYGWIN__)
 # include <windows.h>
+# ifndef _O_BINARY
+#  define _O_BINARY 0
+# endif
 #else
 # ifndef _O_BINARY
 #  define _O_BINARY 0

[ebraminio]

is this a known issue?:

No

Do we have a Cygwin build bot, and if not do we want one?

Why not, great

[khaledhosny]

@davidcarlisle what about this patch instead?

diff --git a/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc b/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc
index a335df308..9f27f520f 100644
--- a/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc
+++ b/source/libs/harfbuzz/harfbuzz-src/src/hb-blob.cc
@@ -490,8 +490,8 @@ hb_blob_t::try_make_writable (void)
 #if defined(_WIN32) || defined(__CYGWIN__)
 # include <windows.h>
 #else
-# ifndef _O_BINARY
-#  define _O_BINARY 0
+# ifndef O_BINARY
+#  define O_BINARY 0
 # endif
 #endif
 
@@ -542,7 +542,7 @@ hb_blob_create_from_file (const char *file_name)
   hb_mapped_file_t *file = (hb_mapped_file_t *) calloc (1, sizeof (hb_mapped_file_t));
   if (unlikely (!file)) return hb_blob_get_empty ();
 
-  int fd = open (file_name, O_RDONLY | _O_BINARY, 0);
+  int fd = open (file_name, O_RDONLY | O_BINARY, 0);
   if (unlikely (fd == -1)) goto fail_without_close;
 
   struct stat st;

[behdad]

If O_BINARY works on cygwin and mingw32, then good. Not sure defining it to 0 is good as that would mask a bug.

[behdad]

This says cygwin has O_BINARY: http://www.cygwin.com/cygwin-ug-net/using-textbinary.html
Not sure why I changed it back then.

[davidcarlisle]

If O_BINARY works on cygwin and mingw32, then good. Not sure defining it to 0 is good as that would mask a bug.

yes I was happy just to isolate where to fix, I wasn't at all confident that setting it to 0 was the correct fix other than it got the make build not to die at that point. I'll try with the diff from @khaledhosny