Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

including ucdn.h hides shared import APIs declared in headers following the include #1470

Closed
zsombi-rw opened this issue Dec 11, 2018 · 0 comments
Closed

including ucdn.h hides shared import APIs declared in headers following the include #1470

zsombi-rw opened this issue Dec 11, 2018 · 0 comments

Comments

@zsombi-rw
Copy link

harfbuzz/src/hb-ucdn/ucdn.h

Line 459 in 1683bb2

#ifdef __cplusplus

By not using HB_END_HEADER, the default visibility for the API included after ucdn.h will stay as hidden, thus all API used from shared libs will be reported as undefined symbols.

Reproduced on Ubuntu 18.04, gcc 7.3.0
@behdad behdad closed this as completed in 9f3a51d Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zsombi-rw