Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62e60322cb9e18b breaks Chrome build #1821

Closed
drott opened this issue Jul 8, 2019 · 2 comments
Closed

62e60322cb9e18b breaks Chrome build #1821

drott opened this issue Jul 8, 2019 · 2 comments
Labels
Chrome Chrome/Chromium project related issues and requests

Comments

@drott
Copy link
Collaborator

drott commented Jul 8, 2019

The Chrome build does not support putting extern "C" declarations inside the function, I get:

../../third_party/harfbuzz-ng/src/src/hb-unicode.cc:138:10: error: expected unqualified-id
  extern "C" hb_unicode_funcs_t *hb_icu_get_unicode_funcs ();
         ^
../../third_party/harfbuzz-ng/src/src/hb-unicode.cc:139:10: error: use of undeclared identifier 'hb_icu_get_unicode_funcs'; did you mean 'hb_ucd_get_unicode_funcs'?
  return hb_icu_get_unicode_funcs ();
         ^~~~~~~~~~~~~~~~~~~~~~~~
         hb_ucd_get_unicode_funcs

but when reverting 62e6032 (which moved the extern declarations inside the function) it builds okay.

I suggest to revert this change if it's not needed for [amalgam].

@drott drott added the Chrome Chrome/Chromium project related issues and requests label Jul 8, 2019
@behdad
Copy link
Member

behdad commented Jul 8, 2019

Yes, please revert.

I thought it might break something but didn't upset out bots.

Sorry about that.

@drott
Copy link
Collaborator Author

drott commented Jul 8, 2019

Okay, I'll revert this one - I prepared a roll with a local revert already, to see if we can get the rounding optimizations past the trybots. Thanks for the quick response.

@drott drott closed this as completed in 2e7021d Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chrome Chrome/Chromium project related issues and requests
Projects
None yet
Development

No branches or pull requests

2 participants