New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hb_pair_t conversion operator #2083

Closed

blueshade7 opened this issue Jan 3, 2020 · 0 comments

Contributor

blueshade7 commented Jan 3, 2020

The third line in this definition of hb_pair_t conversion operator doesn't make sense.

harfbuzz/src/hb-algs.hh

Lines 309 to 312 in 9e48c6e

    
           template <typename Q1, typename Q2, 
        
              hb_enable_if (hb_is_convertible (T1, Q1) && 
        
           	  hb_is_convertible (T2, T2))> 
        
           operator hb_pair_t<Q1, Q2> () { return hb_pair_t<Q1, Q2> (first, second); }

Shouldn't it be hb_is_convertible (T2, Q2) instead of hb_is_convertible (T2, T2)?

The text was updated successfully, but these errors were encountered:

behdad closed this as completed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment