Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hb-ft nullptr scheme #2513

Closed
behdad opened this issue Jun 28, 2020 · 0 comments
Closed

Change hb-ft nullptr scheme #2513

behdad opened this issue Jun 28, 2020 · 0 comments

Comments

@behdad
Copy link
Member

behdad commented Jun 28, 2020

So instead of what we did in #2502 and #2494, I believe the correct way is to NOT call hb_font_set_funcs in _hb_ft_font_set_funcs if _hb_ft_font_create failed. That is, there's no point getting into the callbacks with a nullptr. Right now all callbacks need to protect against it, and the issues we fixed just did that for two that were discovered...

@behdad behdad closed this as completed in 26b9670 Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant