Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop codecov CI check? #3004

Closed
khaledhosny opened this issue Jun 4, 2021 · 2 comments
Closed

Drop codecov CI check? #3004

khaledhosny opened this issue Jun 4, 2021 · 2 comments
Labels
ci Continuous Integration

Comments

@khaledhosny
Copy link
Collaborator

It does not seem anyone is paying attention to the reported fails, they are pretty much ignored (no one is adding extra tests to make it happy), so I don't see what is the point of having the check if passing it is not enforced (at least when it is reasonable).
@khaledhosny khaledhosny added the ci Continuous Integration label Jun 4, 2021
@behdad
Copy link
Member

behdad commented Jun 4, 2021

Agree. Let me see if I can configure it differently.

@behdad
Copy link
Member

behdad commented Jun 4, 2021

Looks like we can. Trying to figure out now.
https://docs.codecov.io/docs/codecovyml-reference

@behdad behdad closed this as completed in 9220634 Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khaledhosny @behdad