Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HB_NO_METRICS build fails on Chrome Android #3482

Closed
drott opened this issue Mar 15, 2022 · 2 comments
Closed

HB_NO_METRICS build fails on Chrome Android #3482

drott opened this issue Mar 15, 2022 · 2 comments

Comments

@drott
Copy link
Collaborator

drott commented Mar 15, 2022

hb_ot_layout_get_baseline_with_fallback is available and unconditionally needs hb_ot_metrics_get_position, compare @bungeman 's analaysis in https://chromium-review.googlesource.com/c/chromium/src/+/3521601/6/third_party/harfbuzz-ng/BUILD.gn#349
@behdad
Copy link
Member

behdad commented Mar 15, 2022

I suggest we make baseline API conditional on HB_NO_METRICS as well. cc @matthiasclasen

@behdad
Copy link
Member

behdad commented Mar 15, 2022

I suggest we make baseline API conditional on HB_NO_METRICS as well. cc @matthiasclasen

Humm. There's HB_NO_BASE for that. @matthiasclasen can you make the hb_ot_metrics_get_position() call guarded please? Also, the hb_ot_metrics_get_position() needs to be replaced with the _with_fallback() version.

@behdad behdad closed this as completed in cad2fe8 Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @drott