[draw] hb_font_get_glyph_shape() always uses the slant of the parent

[khaledhosny]

I’m trying to use hb_font_get_glyph_shape() on a font that has synthetic slant set on it, but I don’t want to apply the slant, so I created a sub font and set the slant on it to zero, but I’m still getting slanted outlines. Is this expected?

[behdad]

Definitely not expected. I think I know why it's happening though.

[behdad]

The parent font already returns shapes slanted. The subfont's slant, if anything, would be added to the parent font. Does that happen? I don't think it does. Anyway, I think that would be the expected behavior, not what you expect.

[behdad]

Does that happen?

I don't think it does, but should be possible to fix.

[behdad]

I don't think it does, but should be possible to fix.

Humm. Seems to work. I'm not sure why.

[behdad]

Oh, because I set the slant on the parent font, nevermind.

[behdad]

Oh, because I set the slant on the parent font, nevermind.

I tested setting slant on the child font only, still seems to work.

[behdad]

Adding the slants don't make sense though. Creating a new sub_font would double-slant. Scratch that. Let me think more.

[behdad]

Oh. It looks like we are double-slanting currently.

[behdad]

Oh. It looks like we are double-slanting currently.

Or maybe not, but something very weird currently going on.

[behdad]

I agree with your initial expectation now. We just have to adjust the outlines for the difference in the slant in the hb_font_get_glyph_shape_default_adaptor_t.

For now, I'm seeing some weird behavior that I'm debugging.

[behdad]

For now, I'm seeing some weird behavior that I'm debugging.

2e9b270

[behdad]

Fixed. Please test.

[khaledhosny]

Verified, thanks!