Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson-build: Linker-error in hb-paint-tests for disabled freetype and cairo #4103

Closed
Emanuesson opened this issue Feb 4, 2023 · 0 comments
Closed

Comments

@Emanuesson
Copy link

I came across this problems, as I wanted to compile a project that depends on
harfbuzz with the meson-build-flag -Dwrap_mode=forcefallback. However,
the problem can also be reproduced on harfbuzz itself:

  • Check out a recent state of harfbuzz (e.g. 6.0.0-978-gcb47dca74)
  • Configure a build-directory with meson-build:
    meson setup build -Dwrap_mode=forcefallback -Dfreetype=disabled -Dcairo=disabled
  • Try to compile and test it with:
    meson compile -C build && meson test -C build

Expected:
All build-targets and tests are build and can be executed successfully

Observed:
Linker complains about a missing reference:
harfbuzz/build/../test/api/test-paint.c:520: undefined reference to 'have_ft_colrv1'

Proposed change:
IMHO the test can easily be made compatible, for the else-case of #ifdef HB_HAS_FREETYPE.
The function have_ft_colrv1 may then just always return FALSE.

@Emanuesson Emanuesson changed the title Linker-error in hb-paint-tests for disabled reetype and cairo Meson-build: Linker-error in hb-paint-tests for disabled reetype and cairo Feb 4, 2023
@Emanuesson Emanuesson changed the title Meson-build: Linker-error in hb-paint-tests for disabled reetype and cairo Meson-build: Linker-error in hb-paint-tests for disabled freetype and cairo Feb 4, 2023
@behdad behdad closed this as completed in 474b99d Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant