Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasm shaper docs create font #4456

Closed
wipfli opened this issue Oct 21, 2023 · 2 comments
Closed

Wasm shaper docs create font #4456

wipfli opened this issue Oct 21, 2023 · 2 comments

Comments

@wipfli
Copy link

wipfli commented Oct 21, 2023

There might be an inconsistency in the wasm shaper docs at https://github.com/harfbuzz/harfbuzz/blob/main/docs/wasm-shaper.md#face-handling-functions

Which one is correct, face_create or get_font_face?
@behdad
Copy link
Member

behdad commented Oct 21, 2023

Which one is correct, face_create or get_font_face?

font_get_face gets a face object from a font object. Those two are different.

face_create creates a font.

There's no get_font_face.

@behdad behdad closed this as completed Oct 21, 2023
@behdad behdad mentioned this issue Oct 21, 2023
Open
@wipfli
Copy link
Author

wipfli commented Oct 22, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @wipfli