Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pedantic warning while using HB_TAG #504

Closed
ksvskushal opened this issue Jul 8, 2017 · 4 comments
Closed

Pedantic warning while using HB_TAG #504

ksvskushal opened this issue Jul 8, 2017 · 4 comments

Comments

@ksvskushal
Copy link

While compiling freetype2, I found the following warning.

hb-common.h:93:29: warning: ISO C restricts enumerator values to range of ‘int’ [-Wpedantic]
 #define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint8_t)(c1))<<24)|(((uint8_t)(c2))<

HB_TAG_MAX seems to be the problem.

hb-common.h:97:20: note: in expansion of macro ‘HB_TAG’
 #define HB_TAG_MAX HB_TAG(0xff,0xff,0xff,0xff)
@behdad
Copy link
Member

behdad commented Jul 14, 2017

Yeah, ignore it.

@behdad behdad closed this as completed Jul 14, 2017
@lionel-
Copy link

lionel- commented Jun 10, 2018

FYI this is causing issues for getting packages accepted in CRAN. No pedantic warning is part of their checking process. If possible, it'd be helpful to have this warning fixed.

@behdad
Copy link
Member

behdad commented Sep 30, 2018

Going to fix it.

@behdad behdad reopened this Sep 30, 2018
@behdad behdad closed this as completed in 90dd255 Sep 30, 2018
@lionel-
Copy link

lionel- commented Oct 1, 2018

Thanks!

@behdad behdad mentioned this issue Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behdad @lionel- @ksvskushal