Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shape() ignores supplied features #83

Closed
khaledhosny opened this issue May 19, 2023 · 0 comments · Fixed by #97
Closed

shape() ignores supplied features #83

khaledhosny opened this issue May 19, 2023 · 0 comments · Fixed by #97

Comments

@khaledhosny
Copy link
Contributor

While reviewing #82 I was surprised to find out that shape() does not actually use supplied features. Logging this so I don’t forget to fix it.
khaledhosny added a commit that referenced this issue Mar 24, 2024
@khaledhosny
Re-implement shapeWithTrace in JS
aacee6e 
Also fixes #83
@khaledhosny khaledhosny linked a pull request Mar 24, 2024 that will close this issue
Re-implement callbacks in JS #97
Merged
khaledhosny added a commit that referenced this issue Mar 24, 2024
@khaledhosny
Re-implement shapeWithTrace in JS
6655c17 
Also fixes #83
khaledhosny added a commit that referenced this issue Mar 24, 2024
@khaledhosny
Re-implement shapeWithTrace in JS
18be250 
Also fixes #83
khaledhosny added a commit that referenced this issue Jul 4, 2024
@khaledhosny
Re-implement shapeWithTrace in JS
96e1cd3 
Also fixes #83
khaledhosny added a commit that referenced this issue Jul 5, 2024
@khaledhosny
Re-implement shapeWithTrace in JS
67c928f 
Also fixes #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-implement callbacks in JS harfbuzz/harfbuzzjs
1 participant
@khaledhosny