Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to HarfBuzz 2.9.0 #101

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Update to HarfBuzz 2.9.0 #101

merged 3 commits into from
Aug 24, 2021

Conversation

khaledhosny
Copy link
Collaborator

Also re-enable Uniscribe shaper, building it should be fixed now.

Also re-enable Uniscribe shaper, building it should be fixed now.
@khaledhosny
Copy link
Collaborator Author

khaledhosny commented Aug 19, 2021

I don’t know what to make of the CI build failure on Linux:

Building cp310-manylinux_x86_64 wheel
CPython 3.10 manylinux x86_64

Setting up build environment...
  
      + /opt/python/cp38-cp38/bin/python -c 'import sys, json, os; json.dump(os.environ.copy(), sys.stdout)'
      + which python
  cibuildwheel: python available on PATH doesn't match our installed instance. If you have modified PATH, ensure that you don't overwrite cibuildwheel's entry or insert python above it.
  Error: Process completed with exit code 1.

@khaledhosny
Copy link
Collaborator Author

So building CPython 3.10 wheels is broken on Linux and searching by this error messages nothing comes up, so it suggests we are alone in experiencing this. cibuildwheel is all black magic to me, so I don’t even know where to start debugging this.

No wheels are built for them already.
Does not seem to work for Python 3.10 and I can’t find a way to set the
image per-python version.
@khaledhosny
Copy link
Collaborator Author

The breakage was apparently caused by the forced manylinux1 image instead of using the default. I don’t know the exact cause, but support for manylinux1 will end on January 1st, 2022, so I guess now is a good time to drop it.

@khaledhosny
Copy link
Collaborator Author

khaledhosny commented Aug 24, 2021

Actually the above issue explicitly states that manylinux1 will not support CPython 3.10, so that is our root cause.

@khaledhosny khaledhosny merged commit eaf24d1 into main Aug 24, 2021
@khaledhosny khaledhosny deleted the harfbuzz-2.9.0 branch August 24, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant