Update to HarfBuzz 4.0.0 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
force-pushed
the
hb-draw-update
branch
2 times, most recently
from
e81bf8b
to
f9bb97e
Compare
|
Blackrenderer uses the draw API, and may be a good test case. Let me know if/when you want me to try out this PR. |
The user_data object should be passed to the callback setter. The old Python way of keeping user_data in the DrawFuncs object still works but is deprecated.
khaledhosny
force-pushed
the
hb-draw-update
branch
from
f9bb97e
to
5d9150c
Compare
It should be ready for testing now. |
khaledhosny
changed the title
|
Is this able to be merged now? We're planning on PR'ing the addition of the repacker API but it's blocked on updating to 4.0.0. |
|
Merged, we can fix any issues before next release. |
|
I just ran my blackrenderer tests with this version, and it works perfectly. I do see differences between the previous int-only output and the current float coordinates, but that's obviously to be expected. I'll just have to adapt my expected results in those few cases. |
|
Excellent ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the stabilization hb-draw API.
TODO: