Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hb_subset_repack_or_fail to new method signature that takes table tag. #132

Merged
merged 2 commits into from
Jul 31, 2022

Conversation

garretrieger
Copy link
Contributor

No description provided.

@khaledhosny
Copy link
Collaborator

The test failure seems to be caused by changes in the message callbacks, please update the test expectations.

Update also the repacker API to pass along table tag.
@khaledhosny khaledhosny merged commit 699b99f into main Jul 31, 2022
@khaledhosny khaledhosny deleted the tag_in_repack branch July 31, 2022 14:56
@anthrotype
Copy link
Member

I guess it's a bit too late, but I think it might have been nicer or more pythonic to add an optional table_tag="" keyword argument to the existing repack method, instead of defining/exporting an additional repack_with_tag method in the public uharfbuzz API. I guess you did that to more closely match Harfbuzz's own C API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants