Skip to content

Commit

Permalink
Reconcile symmetry between handleGet and handlePut
Browse files Browse the repository at this point in the history
  • Loading branch information
Hari Amoor committed Jul 29, 2020
1 parent c9805ec commit e007c29
Showing 1 changed file with 29 additions and 24 deletions.
53 changes: 29 additions & 24 deletions mongofiles/mongofiles.go
Expand Up @@ -419,21 +419,36 @@ func (mf *MongoFiles) put(id interface{}, name string) (bytesWritten int64, err
}

// handlePut contains the logic for the 'put' and 'put_id' commands
func (mf *MongoFiles) handlePut(file string) error {
id, err := mf.parseOrCreateID()
if err != nil {
return err
}
func (mf *MongoFiles) handlePut() error {
handlePutFile := func(mf *MongoFiles, file string) error {
id, err := mf.parseOrCreateID()
if err != nil {
return err
}

log.Logvf(log.Always, "adding gridFile: %v\n", file)
log.Logvf(log.Always, "adding gridFile: %v\n", file)

n, err := mf.put(id, file)
if err != nil {
log.Logvf(log.Always, "error adding gridFile: %v\n", err)
return err
n, err := mf.put(id, file)
if err != nil {
log.Logvf(log.Always, "error adding gridFile: %v\n", err)
return err
}
log.Logvf(log.DebugLow, "copied %v bytes to server", n)
log.Logvf(log.Always, "added gridFile: %v\n", file)

return nil
}

if mf.Command == Put {
for _, filename := range mf.FileNameList {
err := handlePutFile(mf, filename)
if err != nil {
return err
}
}
} else {
return handlePutFile(mf, mf.FileName)
}
log.Logvf(log.DebugLow, "copied %v bytes to server", n)
log.Logvf(log.Always, "added gridFile: %v\n", file)

return nil
}
Expand Down Expand Up @@ -500,18 +515,8 @@ func (mf *MongoFiles) Run(displayHost bool) (output string, finalErr error) {
case Get, GetID:
err = mf.handleGet()

case Put:
// If mongofiles --put ... is called, i.e. with multiple supporting
// arguments, then add gridFiles specified in mf.FileNameList
for _, filename := range mf.FileNameList {
err = mf.handlePut(filename)
if err != nil {
return "", err
}
}

case PutID:
err = mf.handlePut(mf.FileName)
case Put, PutID:
err = mf.handlePut()

case DeleteID:
err = mf.handleDeleteID()
Expand Down

0 comments on commit e007c29

Please sign in to comment.