Navbar #58

haricot · 2020-10-28T10:41:12Z

No description provided.

Merge branch 'releases/1.1' into navbar

last update from jrief/master

fix test missing migrations texteditorconfigfields

ghost · 2020-10-28T10:41:26Z

DeepCode's analysis on #76cd22 found:

ℹ️ 7 minor issues. 👇

Top issues

Description	Example fixes
first party import "from cmsplugin_cascade.bootstrap4.jumbotron import ImageBackgroundMixin" should be placed before "from .plugin_base import BootstrapPluginBase" Occurrences: navbar.py:8 navbar.py:9 navbar.py:10	🔧 Example fixes
Either all return statements in a function should return an expression, or none of them should. Occurrences: navbar.py:58	🔧 Example fixes
Undefined variable 'css_class' Occurrences: navbar.py:148 navbar.py:149 navbar.py:216	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

haricot added 30 commits July 4, 2019 01:22

Update buttons.py

bb7f88c

add plugins bootstrap navbar

85a64d1

add navbarplugin.js

bf4d99b

add conditional required image plug

4b2cf0e

update settings.py

c837d26

add js logic for placeholder

667a8ec

add templates bootstrap Navbar

e953cbc

add mixins bootstrap

59f0102

update bootstrap4/settings.py

080441f

update bootstrap4/navbar_brand_image.html

79dc8a8

update bootstrap4/navbar.py

9255bc5

if button in navbar add css class

79aec8c

fix choices in BootstrapUtilities

61195f7

Update navbar plugins

6e988d6

if simple icon in NavItem add css class

75d4c8e

Correct logic if not check_unique_element_id

e66d914

modify logic if image and required

c3605a3

if link in navItem add css class

2d2c4c2

update buttons.py

38c3059

add classes if parent match

e5cd29f

add classes if specific parent match

32a6a66

Update BootstrapNavbarPlugin

13760c8

add bootstrap4 mixins: positions

aed9b67

update bootstrap4/settings.py

ce6ad20

add BootstrapListsPlugin

ce4476c

Merge branch 'releases/1.0.x' into navbar

c2a6d7f

Update image.py

98674af

Merge pull request #14 from jrief/master

02d6e7e

Merge branch 'releases/1.1' into navbar

fix unneeded import error

ea85d10

add pyproject.toml

eab4c2e

haricot added 25 commits October 28, 2019 23:23

Update test_base.py

0ecf83f

Update test_base.py

32c25a1

Update test_strides.py

afeb76d

Update test_strides.py

1015aa4

Update bootstrap-navbar.json

9793487

Update navbar.py

f811fe1

Merge branch 'master' into navbar

d73426f

Merge branch 'master' into navbar

26c650d

wip navbar

a8a1903

fix wip navbar

143aef4

travis test

32c7303

wip navbar test

a6ed567

Merge pull request #25 from jrief/master

d556eb8

last update from jrief/master

clean code

b2e1a52

Update .travis.yml

01236b8

clean code

53b95f3

clean code

9951ba2

wip navbar

1542447

fix wip navbar test

765fcda

Merge pull request #26 from haricot/patch-50

95d4018

fix test missing migrations texteditorconfigfields

add js/vanilla func:placeholder_position_top(title)

21ebb44

add BootstrapNavBarPlugin support angular-ui

2cb1b13

add BootstrapNavBarPlugin support angular-ui

5ac027b

add BootstrapListsSeparatorPlugin <li class="w-100"></li>

34cb07d

Create navbar_list_separator.html

f7d8fc1

haricot added 3 commits October 28, 2020 12:10

fix merge

4aa0c8a

fix lists.py:import order

8e763fa

fix navbar.py: import order

76cd22e

haricot force-pushed the navbar branch from 81aef82 to 76cd22e Compare October 28, 2020 13:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navbar #58

Navbar #58

haricot commented Oct 28, 2020

ghost commented Oct 28, 2020 •

edited by ghost

Loading

Navbar #58

Are you sure you want to change the base?

Navbar #58

Conversation

haricot commented Oct 28, 2020

ghost commented Oct 28, 2020 • edited by ghost Loading

DeepCode's analysis on #76cd22 found:

Top issues

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost commented Oct 28, 2020 •

edited by ghost

Loading