forked from vyperlang/vyper
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mem2stack #7
Draft
charles-cooper
wants to merge
36
commits into
harkal:feature/venom_updates
Choose a base branch
from
charles-cooper:mem2stack
base: feature/venom_updates
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Mem2stack #7
charles-cooper
wants to merge
36
commits into
harkal:feature/venom_updates
from
charles-cooper:mem2stack
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this unifies various functions which modify global settings: anchor_opt_level, anchor_evm_version, _set_debug
small refactor: refactor replicated code for variable deallocatoin
it better belongs in a separate pass
charles-cooper
force-pushed
the
mem2stack
branch
from
March 24, 2024 13:05
80eb1ea
to
54e3ed2
Compare
charles-cooper
force-pushed
the
mem2stack
branch
from
March 24, 2024 15:22
8552f68
to
1d834d9
Compare
we don't need to poison the whole chain of loads/stores; just need to make sure loads/stores at the end of the chain are issued
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
draft mem2stack implementation. somewhat crude :) and with the following bugs:
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture