Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF's aren't being ignored #96

Closed
NathanBeddoeWebDev opened this issue May 13, 2023 · 1 comment
Closed

PDF's aren't being ignored #96

NathanBeddoeWebDev opened this issue May 13, 2023 · 1 comment

Comments

@NathanBeddoeWebDev
Copy link

Describe the bug

Summary
When scanning our site, I've noticed that PDF content types are still being added to the report, and failing in lighthouse. My current solution is to just include those paths in the excludedUrls config, but long term that's not ok.

I've confirmed that the paths are returning an application/pdf content type, and I can see that in

return { success: false, message: `Invalid content-type header: ${contentType}.` }
we should be ignoring these files, so not sure what's going on yet.

image

Reproduction

node packages/cli/dist/cli.mjs --site https://www.youi.com.au

System / Nuxt Info

- Operating System: `Darwin`
- Node Version:     `v18.12.1`
- Nuxt Version:     `3.1.1`
- Nitro Version:    `2.1.0`
- Package Manager:  `pnpm@8.5.0`
- Builder:          `vite`
- User Config:      `-`
- Runtime Modules:  `-`
- Build Modules:    `-`
@harlan-zw
Copy link
Owner

Thanks @NathanBeddoeWebDev, this is fixed in 0.7.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants