Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1 #31

Merged
merged 59 commits into from Mar 10, 2022
Merged

Version 1 #31

merged 59 commits into from Mar 10, 2022

Conversation

mnekx
Copy link
Collaborator

@mnekx mnekx commented Mar 10, 2022

Description

In this version, the following was done:

Type of change

  • Set up the project with Webpack and Jest
  • Add tests for items counter
  • Find external API
  • Add footer
  • Add header
  • Choose assets
  • Display list of items on the Homepage
  • Add all items counter on the Homepage
  • Display Comments pop up with selected item's details
  • Display number of likes for each item on the Homepage
  • Display comments for a given item on the Comments pop-up
  • Create feature: add new like
  • Create feature: add new comment
  • Add comments counter
  • Add tests for comments counter
  • Launched to Github pages here
  • Link to Video documentation here

Checklist:

  • No linter errors.
  • I have used correct Gitflow.
  • Work is documented in a professional way.
  • List of JavaScript best practices is followed.

harlexkhal and others added 30 commits March 8, 2022 02:30
connect to food api + add item list unit test
connect application engine to ui + modify ui
Copy link

@ShoiraTa ShoiraTa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: CHANGES REQUIRED 🟡

Hi team,

👍 This your project is looks great! All the functionality work.

There is only 1 issue that you still need to work on to go to the next project but you are almost there!

woohoo-youre-almost

Required Changes ♻️

Check the comments under the review.


Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Comment on lines +19 to +21
<ul class="nav-menu d-flex">
<li class="nav-item"><a href="index.html">View more</a></li>
<li class="nav-item"><a href="index.html"><span class="item-count">0</span> Meal(s) found!</a></li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Based on project requirements, the page should have a navigation similar to the given wireframe. Pay attention that the wireframe has 3 pages, Spaces, Planets, Races:

Screenshot 2022-03-10 at 18 33 49

Please add 3 pages based on some category, for example, you can make deserts, vegetarian, seafood, like I did in my capstone project, feel free to check it here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ShoiraTa, I thought the wireframe was there as a guide, not a core requirement. the view more on the navigation navigates between more than just 3 categories, when you click on view more or any of the navigations it randomly selects a new category. Thanks for the review
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harlexkhal , sorry for confusion, but it looks like you are right. Building more pages is an additional requirement. Please request a review, it will be approved 🙌

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShoiraTa

Copy link

@Ghiftee Ghiftee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED ♻️♻️

Hi @mnekx, @harlexkhal

Your project is complete! There is nothing else to say other than... it's time to merge it 🚀
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

@harlexkhal harlexkhal merged commit 427830a into main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants