connect to food api + add item list unit test #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
harlexkhal
commented
Mar 8, 2022
harlexkhal
commented
- Connect to food API
- Add unit test for a list of home page items
mnekx
requested changes
Mar 8, 2022
__Testbase__/unit.test.js
Outdated
Comment on lines
2
to
4
|
|
||
| describe('Food Application ', () => { | ||
| test('Home page item count', () => { |
There was a problem hiding this comment.
The test follows the AAA pattern, one thing though: consider below:
The describe could be "Food Items" and test could be "count items" to better describe the test. Dont you think?
mnekx
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.