Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An attempt to work around a gopkg.in/module error in a dependency #100

Merged
merged 2 commits into from
Aug 31, 2019

Conversation

moranmathias
Copy link
Contributor

I tried to update this module to use your latest version using the command below, and ran into a grungy go modules error.

go get -u -v github.com/harlow/kinesis-consumer@latest
Fetching https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1
Fetching https://gopkg.in/redis.v5?go-get=1
Parsing meta tags from https://gopkg.in/redis.v5?go-get=1 (status code 200)
get "gopkg.in/redis.v5": found meta tag get.metaImport{Prefix:"gopkg.in/redis.v5", VCS:"git", RepoRoot:"https://gopkg.in/redis.v5"} at https://gopkg.in/redis.v5?go-get=1
Parsing meta tags from https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1 (status code 200)
get "gopkg.in/DATA-DOG/go-sqlmock.v1": found meta tag get.metaImport{Prefix:"gopkg.in/DATA-DOG/go-sqlmock.v1", VCS:"git", RepoRoot:"https://gopkg.in/DATA-DOG/go-sqlmock.v1"} at https://gopkg.in/DATA-DOG/go-sqlmock.v1?go-get=1
go: finding github.com/jmespath/go-jmespath latest
Fetching https://golang.org/x/crypto?go-get=1
Parsing meta tags from https://golang.org/x/crypto?go-get=1 (status code 200)
get "golang.org/x/crypto": found meta tag get.metaImport{Prefix:"golang.org/x/crypto", VCS:"git", RepoRoot:"https://go.googlesource.com/crypto"} at https://golang.org/x/crypto?go-get=1
go: finding github.com/smartystreets/go-aws-auth latest
Fetching https://golang.org/x/net?go-get=1
Parsing meta tags from https://golang.org/x/net?go-get=1 (status code 200)
get "golang.org/x/net": found meta tag get.metaImport{Prefix:"golang.org/x/net", VCS:"git", RepoRoot:"https://go.googlesource.com/net"} at https://golang.org/x/net?go-get=1
Fetching https://golang.org/x/text?go-get=1
Parsing meta tags from https://golang.org/x/text?go-get=1 (status code 200)
get "golang.org/x/text": found meta tag get.metaImport{Prefix:"golang.org/x/text", VCS:"git", RepoRoot:"https://go.googlesource.com/text"} at https://golang.org/x/text?go-get=1
go: finding github.com/jpillora/backoff latest
Fetching https://golang.org/x/sys?go-get=1
go: finding github.com/aphistic/golf latest
go: finding github.com/aybabtme/rgbterm latest
Parsing meta tags from https://golang.org/x/sys?go-get=1 (status code 200)
get "golang.org/x/sys": found meta tag get.metaImport{Prefix:"golang.org/x/sys", VCS:"git", RepoRoot:"https://go.googlesource.com/sys"} at https://golang.org/x/sys?go-get=1
go: finding github.com/tj/go-kinesis latest
go: finding golang.org/x/net latest
go: finding github.com/tj/go-elastic latest
go: finding golang.org/x/crypto latest
Fetching https://golang.org/x/sync?go-get=1
go: finding github.com/tj/assert latest
Parsing meta tags from https://golang.org/x/sync?go-get=1 (status code 200)
get "golang.org/x/sync": found meta tag get.metaImport{Prefix:"golang.org/x/sync", VCS:"git", RepoRoot:"https://go.googlesource.com/sync"} at https://golang.org/x/sync?go-get=1
Fetching https://gopkg.in/yaml.v2?go-get=1
Parsing meta tags from https://gopkg.in/yaml.v2?go-get=1 (status code 200)
get "gopkg.in/yaml.v2": found meta tag get.metaImport{Prefix:"gopkg.in/yaml.v2", VCS:"git", RepoRoot:"https://gopkg.in/yaml.v2"} at https://gopkg.in/yaml.v2?go-get=1
go: finding golang.org/x/sys latest
Fetching https://gopkg.in/tomb.v1?go-get=1
Fetching https://gopkg.in/check.v1?go-get=1
Parsing meta tags from https://gopkg.in/tomb.v1?go-get=1 (status code 200)
get "gopkg.in/tomb.v1": found meta tag get.metaImport{Prefix:"gopkg.in/tomb.v1", VCS:"git", RepoRoot:"https://gopkg.in/tomb.v1"} at https://gopkg.in/tomb.v1?go-get=1
Parsing meta tags from https://gopkg.in/check.v1?go-get=1 (status code 200)
get "gopkg.in/check.v1": found meta tag get.metaImport{Prefix:"gopkg.in/check.v1", VCS:"git", RepoRoot:"https://gopkg.in/check.v1"} at https://gopkg.in/check.v1?go-get=1
go: finding github.com/kr/logfmt latest
go: finding golang.org/x/sync latest
go: gopkg.in/DATA-DOG/go-sqlmock.v1@v1.3.3: go.mod has non-....v1 module path "github.com/DATA-DOG/go-sqlmock" at revision v1.3.3
go: finding gopkg.in/tomb.v1 latest
go: finding gopkg.in/check.v1 latest
go: finding github.com/mgutz/ansi latest
go get: error loading module requirements

This work around seem fix the problem, also it would be great if you can create a new version tag to lock this changes.

Thanks

Copy link
Owner

@harlow harlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Will get this merged soon along w/ a new tag 👍

@harlow harlow merged commit 71bbc39 into harlow:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants