fix nil pointer dereference on AWS errors #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2022 12:52
before the previous commit e465b09, client errors panicked the reader, so consumers would pick up sharditerator errors by virtue of their server crashing and burning. Now that client errors are properly returned, the behaviour of listShards is problematic because it absorbs any client errors it gets. The result of these two things now is that if you hit an aws error, your server will go into an endless scan loop you can't detect and can't easily recover from. To avoid that, listShards will now stop if it hits a client error.
jwhitaker-swiftnav
force-pushed
the
fix-stream-err
branch
from
7343e75
to
f818bc9
Compare
|
Makes sense, thanks for PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, currently certain AWS errors cause a segfault instead of returning the err :(
For example, if your stream gets recreated outside of your app, your stored sharditerator is no longer valid and you'll get an AWS error when you try to use it.
EDIT: I've also changed listShards error handling - because we no longer panic, the "loop forever even if you error" behaviour of listShards is now quite problematic. I think it should return
error- if client wants to loop and try again forever they are free to do so.