Introduce ScanFunc signature and remove ScanStatus #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harlow
force-pushed
the
hw-refactor-scan-status
branch
from
141af25
to
48a4b2f
Compare
Major changes: * Remove the concept of `ScanStatus` in favor of custom errors Minor changes: * Move optional config to new file #75
harlow
force-pushed
the
hw-refactor-scan-status
branch
from
1e13e72
to
b1d49ff
Compare
|
Hey @harlow thanks for your work and time spent in this lib, so, I think there are a lot of great features in this PR, do you need any help to finish it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
ScanStatusSkipCheckpointfor special cases when we don't want to checkpointMinor changes:
See conversation on #75 for more details