Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all albums are populating in the library #48

Closed
ruralTom opened this issue Mar 2, 2021 · 5 comments
Closed

Not all albums are populating in the library #48

ruralTom opened this issue Mar 2, 2021 · 5 comments
Assignees
Labels
improvement Improvement to already existing code

Comments

@ruralTom
Copy link

ruralTom commented Mar 2, 2021

I think it might be an issue with the app not going deeper than 1 folder level?

My music folder has a bunch of random tracks dumped into it, those aren't showing up. I have folders for each artist and albums folders are nested in each musician's folder - those aren't showing up in my collection either.

Is this by design, am I doing it wrong?

@mytja
Copy link
Member

mytja commented Mar 2, 2021

Hello!
Yes, as far as I know, it indexes only in Music folder, no other folders inside/outside of this folder, but we will probably add option to index a whole phone, soon, I guess 😅
Thank you for your support

@alexmercerind alexmercerind self-assigned this Mar 3, 2021
@alexmercerind alexmercerind added the improvement Improvement to already existing code label Mar 3, 2021
@alexmercerind
Copy link
Member

Hi there @ruralTom !

Nice to see you up here.

  • Yeah, you are indeed correct, app is intentionally not scanning Music folder recursively. (And it's a one liner fix)
  • The musician's folders are also intentionally removed as that wasn't much stable to give to users at that point.

In future:

  • You will be able to choose and select custom folder to scan (and it will go to deeper folders).
  • You will be able to get time synced lyrics inside the app for all your music.

It's a project, which is still in development. It requires spare time from my schedule, to add & fix things.
Will let you know, once I fix these.

Greetings.

@ruralTom
Copy link
Author

ruralTom commented Mar 3, 2021

Hi there @ruralTom !

Nice to see you up here.

* Yeah, you are indeed correct, app is intentionally not scanning Music folder recursively. (And it's a one liner fix)

* The musician's folders are also intentionally removed as that wasn't much stable to give to users at that point.

In future:

* You will be able to choose and select custom folder to scan (and it will go to deeper folders).

* You will be able to get time synced lyrics inside the app for all your music.

It's a project, which is still in development. It requires spare time from my schedule, to add & fix things.
Will let you know, once I fix these.

Greetings.

No hurry or nothing ! I can see this is a labor of love.

Thank you.

@alexmercerind
Copy link
Member

Hi there @ruralTom !
Thanks for the love, the fix is landed in the latest release.

Checkout here here.

@ruralTom
Copy link
Author

Excellent! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to already existing code
Projects
None yet
Development

No branches or pull requests

3 participants