Update deposit contract according to v0.6.1 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I've not found this goddamn **** https://github.com/harmony-dev/beacon-chain-java/pull/130/files#diff-9b854443634f1745881ecae0970951edR174 anywhere except deposit contract sources. Am I correct it's really required and it couldn't be simplified? Also some docs suggests using call of |
mkalinin
approved these changes
May 14, 2019
pow/core/src/main/java/org/ethereum/beacon/pow/AbstractDepositContract.java
Outdated
Show resolved
Hide resolved
| return zeroHashes[distanceFromBottom]; | ||
| } | ||
|
|
||
| // # Compute a Merkle root of a right-zerobyte-padded 2**32 sized tree |
There was a problem hiding this comment.
Where does this Python code come from? Could we annotate its source in a class header?
pow/core/src/main/java/org/ethereum/beacon/pow/MinimalMerkle.java
Outdated
Show resolved
Hide resolved
mkalinin
approved these changes
May 20, 2019
|
@mkalinin done |
Nashatyrev
approved these changes
May 21, 2019
|
@Nashatyrev ready for re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quotations to better understand this update:
As you see this PR doesn't look like a production version of deposit root/proofs supplier, so I will be glad to give any feedback and help to move it to something we could really use in production.