Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing SSZ offset based variable size elements serialization #132

Merged
merged 16 commits into from
May 16, 2019

Conversation

zilm13
Copy link
Member

@zilm13 zilm13 commented May 14, 2019

Resolving #124

Regarding removed BytesValue concat/wrap optimization:
current optimization causes StackOverflowError on big lists, say, of 8192 elements (we have such lists in randao mixes, for example). At first I've tried to solve StackOverflow with 10c2543 but ongoing measurement shows that this optimization is not working anymore, at least for current SSZ implementation:

ModelsSerializeTest.beaconStateTest() running time:
MAX_GENERATION = 8 - 64 seconds
MAX_GENERATION = 32 - 370 seconds
copy everytime, no optimization -  2 seconds

so I've removed it finally. I guess, rebuilt SSZ need some new optimization at different view.

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mkalinin mkalinin merged commit 9cbde88 into develop May 16, 2019
@zilm13 zilm13 deleted the feature/ssz-sos branch May 16, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants