Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge newnode class and handling into node class #272

Closed
LeoHChen opened this issue Jan 17, 2019 · 3 comments
Closed

Merge newnode class and handling into node class #272

LeoHChen opened this issue Jan 17, 2019 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@LeoHChen
Copy link
Contributor

newnode is now used only for beacon chain connection. It is causing problem for me now and I have to workaround.

when a new host is started, its selfPeer will generate multiaddress and the keypair. However, since didn't persist the keys, I have to pass it to the real node host. It is related to the issue #271 .

If we persist the keys, there won't be a problem when the real node host launched. We have to merge newnode with node class with one time init of the host structure. Either way, that's the right fix of the redundant newnode.

@LeoHChen LeoHChen added the help wanted Extra attention is needed label Jan 17, 2019
@LeoHChen LeoHChen self-assigned this Jan 17, 2019
@alajko
Copy link
Contributor

alajko commented Jan 17, 2019

This will be addressed in the beaconchain design document.

@alajko alajko mentioned this issue Jan 22, 2019
4 tasks
@alajko
Copy link
Contributor

alajko commented Jan 22, 2019

#292

@LeoHChen
Copy link
Contributor Author

not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants