Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Eslint for Deno lint #201

Closed
wants to merge 9 commits into from
Closed

Switch Eslint for Deno lint #201

wants to merge 9 commits into from

Conversation

MierenManz
Copy link
Contributor

About

Alot of types get fucked because of eslint.
V3 isn't out or being developed yet but I think that switching to deno lint can improve alot of types by default.
I think this because eslint doesn't understand deno's module resolving system and thus get's alot of implicit any
deno lint does understand the resolving system and can infer types alot better than eslint.

I think it is best to switch even if v2 will have a limited life cycle

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes. (Could be, idk)

@MierenManz
Copy link
Contributor Author

I accidently started this from the wrong branch. So it also has changes from args_parser pr 😓
I hope that isn't a problem tho...

Lemme know what people think about this cuz then I'll do a second pass and fix as much types and linting warnings as possible

@Helloyunho
Copy link
Member

you should at least run prettier

@MierenManz
Copy link
Contributor Author

I had alot of comments and I linked all of them. Forgot to put them here. That's why I didn't run prettier

@MierenManz
Copy link
Contributor Author

I had alot of comments and I linked all of them. Forgot to put them here. That's why I didn't run prettier

src/client/client.ts 280
src/client/shard.ts 22
src/client/shard.ts 46
src/client/shard.ts 134
src/commands/client.ts 82
src/gateway/handlers/reconnect.ts 5
src/gateway/managers/base.ts 14
src/gateway/managers/base.ts 74
src/gateway/managers/emojis.ts 16
src/gateway/rest/bucket.ts 94
src/types/channel.ts 53

These are all the comments I had

@MierenManz
Copy link
Contributor Author

I kinda regret doing this. V2 is gonna be out basically within the next week. So idk if it is worth contingent this.
@DjDeveloperr and @Helloyunho what are your thoughts?

@MierenManz
Copy link
Contributor Author

I would like a reply to my last comment @DjDeveloperr or @Helloyunho 😅

@MierenManz
Copy link
Contributor Author

Discussed in discord.
Closing this

@MierenManz MierenManz closed this Aug 2, 2021
@MierenManz MierenManz deleted the fuck_eslint_deno_lint_bae branch August 11, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants