-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Eslint for Deno lint #201
Conversation
I accidently started this from the wrong branch. So it also has changes from args_parser pr 😓 Lemme know what people think about this cuz then I'll do a second pass and fix as much types and linting warnings as possible |
you should at least run prettier |
I had alot of comments and I linked all of them. Forgot to put them here. That's why I didn't run prettier |
…k_eslint_deno_lint_bae
…ck_eslint_deno_lint_bae
src/client/client.ts 280 These are all the comments I had |
I kinda regret doing this. V2 is gonna be out basically within the next week. So idk if it is worth contingent this. |
I would like a reply to my last comment @DjDeveloperr or @Helloyunho 😅 |
Discussed in discord. |
About
Alot of types get fucked because of eslint.
V3 isn't out or being developed yet but I think that switching to deno lint can improve alot of types by default.
I think this because eslint doesn't understand deno's module resolving system and thus get's alot of implicit
any
deno lint does understand the resolving system and can infer types alot better than eslint.
I think it is best to switch even if v2 will have a limited life cycle
Status