FYI: Sync Calibre to KOReader seems broken, user feedback needed

[kyxap]

Hi all,

The feature is broken at this moment and I'm not sure if I there anyone who is using it. So please let me know if it's needed! And I will try to fix it as well. As of now I will disable UI element to avoid any frustration.

Current issue on windows:

1. If running in non debug mode:

calibre, version 7.15.0
ERROR: Unhandled exception: <b>PermissionError</b>:[WinError 5] Access is denied: 'Utopia of Rules_ On Technology, Stupidity, and the Secret Joys of Bureaucracy, The - David Graeber &amp; Devid Griebier.sdr'

calibre 7.15  embedded-python: True
Windows-10-10.0.22631-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.22631')
Python 3.11.5
Windows: ('10', '10.0.22631', 'SP0', 'Multiprocessor Free')
Interface language: None
EXE path: C:\Program Files\Calibre2\calibre.exe
Successfully initialized third party plugins: Extract ISBN (1, 6, 3) && Goodreads (1, 8, 2) && Goodreads Sync (1, 16, 8) && KOReader Sync (0, 6, 2)
Traceback (most recent call last):
  File "calibre_plugins.koreader.action", line 674, in sync_missing_sidecars_to_koreader
  File "calibre_plugins.koreader.action", line 610, in push_metadata_to_koreader_sidecar
  File "os.py", line 225, in makedirs
PermissionError: [WinError 5] Access is denied: 'Utopia of Rules_ On Technology, Stupidity, and the Secret Joys of Bureaucracy, The - David Graeber & Devid Griebier.sdr'

2. If running calibre in debug (e.g. terminal pwd is in Downloads)

Sidecars will be dowaloded locally in that folder:

But UI going to show that all sidecar is missing

calibre, version 7.15.0
Success: 6 books on device without sidecars.
Sidecar creation succeeded for 6.
Sidecar creation failed for 0.
No attempt made for 0 (no metadata in Calibre to push).
See below for details.

  {
    "result": "success",
    "book_id": 311,
    "book_uuid": "d840bffc-c9b9-4043-8424-e4c2a4ff8854",
    "sidecar_path": "Utopiia pravil. O tiekhnologhiiakh, ghluposti i tainom obaianii biurokratii - David Graeber & Devid Griebier.sdr/metadata.epub.lua"
  }
]

Some logic bug and some file access problem as well.

Put your 👍 or 👎 if you need this or better to focus on something else

[charlesangus]

It's a useful feature when you need it, which is basically just when setting up a new reader, or after a factory reset/similar wipe off your reader. Not really any other way to get eg your highlights/bookmarks back on to the reader that I'm aware of. So while I'm not "using it right now", it's definitely something I (and presumably others) will need when upgrading or resetting our readers.

…

On Sat., Jul. 27, 2024, 14:04 kyxap, ***@***.***> wrote: Hi all, image.png (view on web) <https://github.com/user-attachments/assets/27242a47-135b-430a-94f1-987997c6e170> The feature is broken at this moment and I'm not sure if I there anyone who is using it. So please let me know if it's needed! And I will try to fix it as well. As of now I will disable UI element to avoid any frustration. Current issue on windows: 1. If running in non debug mode: calibre, version 7.15.0 ERROR: Unhandled exception: <b>PermissionError</b>:[WinError 5] Access is denied: 'Utopia of Rules_ On Technology, Stupidity, and the Secret Joys of Bureaucracy, The - David Graeber &amp; Devid Griebier.sdr' calibre 7.15 embedded-python: True Windows-10-10.0.22631-SP0 Windows ('64bit', 'WindowsPE') ('Windows', '10', '10.0.22631') Python 3.11.5 Windows: ('10', '10.0.22631', 'SP0', 'Multiprocessor Free') Interface language: None EXE path: C:\Program Files\Calibre2\calibre.exe Successfully initialized third party plugins: Extract ISBN (1, 6, 3) && Goodreads (1, 8, 2) && Goodreads Sync (1, 16, 8) && KOReader Sync (0, 6, 2) Traceback (most recent call last): File "calibre_plugins.koreader.action", line 674, in sync_missing_sidecars_to_koreader File "calibre_plugins.koreader.action", line 610, in push_metadata_to_koreader_sidecar File "os.py", line 225, in makedirs PermissionError: [WinError 5] Access is denied: 'Utopia of Rules_ On Technology, Stupidity, and the Secret Joys of Bureaucracy, The - David Graeber & Devid Griebier.sdr' 2. If running calibre in debug (e.g. terminal pwd is in Downloads) image.png (view on web) <https://github.com/user-attachments/assets/91c15622-c57c-47b2-905f-d80b3be2e6a0> Sidecars will be dowaloded locally in that folder: But UI going to show that all sidecar is missing image.png (view on web) <https://github.com/user-attachments/assets/cef98d01-8a60-4f0e-8ef8-5dab4639e4fe> calibre, version 7.15.0 Success: 6 books on device without sidecars. Sidecar creation succeeded for 6. Sidecar creation failed for 0. No attempt made for 0 (no metadata in Calibre to push). See below for details. { "result": "success", "book_id": 311, "book_uuid": "d840bffc-c9b9-4043-8424-e4c2a4ff8854", "sidecar_path": "Utopiia pravil. O tiekhnologhiiakh, ghluposti i tainom obaianii biurokratii - David Graeber & Devid Griebier.sdr/metadata.epub.lua" } ]```Some logic bug and some file access problem as well.Put your 👍 or 👎 if you need this or better to focus on somethin else — Reply to this email directly, view it on GitHub <#28>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABD5T4JP74USHYVV62FRJ2LZOPOLNAVCNFSM6AAAAABLSB3BUWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTGNJXGYYTEMI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[charlesangus]

But from that traceback, it sounds like you have a permissions issue, which may or may not have much to do with the plugin itself? On Sat., Jul. 27, 2024, 16:13 Charles Taylor, ***@***.***> wrote:

…

It's a useful feature when you need it, which is basically just when setting up a new reader, or after a factory reset/similar wipe off your reader. Not really any other way to get eg your highlights/bookmarks back on to the reader that I'm aware of. So while I'm not "using it right now", it's definitely something I (and presumably others) will need when upgrading or resetting our readers. On Sat., Jul. 27, 2024, 14:04 kyxap, ***@***.***> wrote: > Hi all, > image.png (view on web) > <https://github.com/user-attachments/assets/27242a47-135b-430a-94f1-987997c6e170> > > The feature is broken at this moment and I'm not sure if I there anyone > who is using it. So please let me know if it's needed! And I will try to > fix it as well. As of now I will disable UI element to avoid any > frustration. > > Current issue on windows: > > 1. If running in non debug mode: > > calibre, version 7.15.0 > ERROR: Unhandled exception: <b>PermissionError</b>:[WinError 5] Access is denied: 'Utopia of Rules_ On Technology, Stupidity, and the Secret Joys of Bureaucracy, The - David Graeber &amp; Devid Griebier.sdr' > > calibre 7.15 embedded-python: True > Windows-10-10.0.22631-SP0 Windows ('64bit', 'WindowsPE') > ('Windows', '10', '10.0.22631') > Python 3.11.5 > Windows: ('10', '10.0.22631', 'SP0', 'Multiprocessor Free') > Interface language: None > EXE path: C:\Program Files\Calibre2\calibre.exe > Successfully initialized third party plugins: Extract ISBN (1, 6, 3) && Goodreads (1, 8, 2) && Goodreads Sync (1, 16, 8) && KOReader Sync (0, 6, 2) > Traceback (most recent call last): > File "calibre_plugins.koreader.action", line 674, in sync_missing_sidecars_to_koreader > File "calibre_plugins.koreader.action", line 610, in push_metadata_to_koreader_sidecar > File "os.py", line 225, in makedirs > PermissionError: [WinError 5] Access is denied: 'Utopia of Rules_ On Technology, Stupidity, and the Secret Joys of Bureaucracy, The - David Graeber & Devid Griebier.sdr' > > > 2. If running calibre in debug (e.g. terminal pwd is in Downloads) > > image.png (view on web) > <https://github.com/user-attachments/assets/91c15622-c57c-47b2-905f-d80b3be2e6a0> > > Sidecars will be dowaloded locally in that folder: > > But UI going to show that all sidecar is missing > image.png (view on web) > <https://github.com/user-attachments/assets/cef98d01-8a60-4f0e-8ef8-5dab4639e4fe> > > calibre, version 7.15.0 > Success: 6 books on device without sidecars. > Sidecar creation succeeded for 6. > Sidecar creation failed for 0. > No attempt made for 0 (no metadata in Calibre to push). > See below for details. > > { > "result": "success", > "book_id": 311, > "book_uuid": "d840bffc-c9b9-4043-8424-e4c2a4ff8854", > "sidecar_path": "Utopiia pravil. O tiekhnologhiiakh, ghluposti i tainom obaianii biurokratii - David Graeber & Devid Griebier.sdr/metadata.epub.lua" > } > ]```Some logic bug and some file access problem as well.Put your 👍 or 👎 if you need this or better to focus on somethin else > > — > Reply to this email directly, view it on GitHub > <#28>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABD5T4JP74USHYVV62FRJ2LZOPOLNAVCNFSM6AAAAABLSB3BUWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQZTGNJXGYYTEMI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> >

[kyxap]

It's a useful feature when you need it, which is basically just when setting up a new reader, or after a factory reset/similar wipe off your reader. Not really any other way to get eg your highlights/bookmarks back on to the reader that I'm aware of.

I see your point but usually it's much simpler to backup (and recomended) koreader or just books with sidecar then rely on external software :)

[kyxap]

But from that traceback, it sounds like you have a permissions issue, which may or may not have much to do with the plugin itself?

yeah, I assume because I'm using windows but in debug mode it still did not work (file was places in windows folder instead of device) so still need to debug and find the root cause.

[charlesangus]

I guess in my mind syncing the sidecars back to Calibre _is_ my backup.

…

On Sat., Jul. 27, 2024, 19:22 kyxap, ***@***.***> wrote: But from that traceback, it sounds like you have a permissions issue, which may or may not have much to do with the plugin itself? yeah, I assume because I'm using windows but in debug mode it still did not work (file was places in windows folder instead of device) so still need to debug and find the root cause. — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABD5T4JBESIV6XAWENUYBDLZOQTTVAVCNFSM6AAAAABLSB3BUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGI4DAMRSGE> . You are receiving this because you commented.Message ID: ***@***.***>

[kyxap]

Put your voice then.
Also do you wanna test it on your end and see how it works with all recent changes? I can upload version with enabled feature for testing

[charlesangus]

I wrote this feature initially, so yeah, I can look into why it's not working for you if/when I can find the time.

Things I can see from looking over the code and your errors:

• may not be getting the path correctly for this case (which is not a real device, I suspect it gets the path ok for a real device)
• some kind of permissions issue (possibly related - looks like it may be trying to write to pwd/your_path or /your_path instead of the fully-qualified path, which would potentially do it
• bad error handling (should be reporting failure, not success)

Doesn't look hard to fix.

[kyxap]

enabled in v0.6.5 to get user feedback