Merge pull request #80 from Illianthe/parse-key-value

Allow values in key/value pairs to contain '=' characters
harness · Jan 31, 2018 · f1e221f · f1e221f
2 parents e963f92 + 06de2e5
commit f1e221f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/drone/internal/util.go b/drone/internal/util.go
@@ -87,7 +87,7 @@ func ParseRepo(str string) (user, repo string, err error) {
 func ParseKeyPair(p []string) map[string]string {
 	params := map[string]string{}
 	for _, i := range p {
-		parts := strings.Split(i, "=")
+		parts := strings.SplitN(i, "=", 2)
 		if len(parts) != 2 {
 			continue
 		}

diff --git a/drone/internal/util_test.go b/drone/internal/util_test.go
@@ -3,11 +3,14 @@ package internal
 import "testing"
 
 func TestParseKeyPair(t *testing.T) {
-	s := []string{"FOO=bar", "BAR=", "INVALID"}
+	s := []string{"FOO=bar", "BAR=", "BAZ=qux=quux", "INVALID"}
 	p := ParseKeyPair(s)
 	if p["FOO"] != "bar" {
 		t.Errorf("Wanted %q, got %q.", "bar", p["FOO"])
 	}
+	if p["BAZ"] != "qux=quux" {
+		t.Errorf("Wanted %q, got %q.", "qux=quux", p["BAZ"])
+	}
 	if _, exists := p["BAR"]; !exists {
 		t.Error("Missing a key with no value. Keys with empty values are also valid.")
 	}