[FFM-5307] - .NET SDK - Fix for prereq identifier + update ff-test-cases #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to use latest tests What When a feature depends on another prereq feature being true, the evaluation fails if the value and identifier are different values in the prereq. Update code to use latest ff-test-cases JSON format. Some additional fixes were needed including Null reference exception and incorrect OR handling in groups when latest JSON was used. Why The checkPreRequisite() method incorrectly uses the value of the prereq instead of the identifier. Testing Tested locally with new ff-test-cases JSON + sanity checks with example program
erdirowlands
approved these changes
Nov 28, 2022
davejohnston
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-5307 - .NET SDK - Fix for prereq identifier + update JSON parse to use latest tests
What
When a feature depends on another prereq feature being true, the evaluation fails if the value and identifier are different values in the prereq. Update code to use latest ff-test-cases JSON format which adds ~90 additional tests. Some additional fixes were needed including Null reference exception and incorrect OR handling in groups when latest JSON was used.
Why
The checkPreRequisite() method incorrectly uses the value of the prereq instead of the identifier.
Testing
Tested locally with new ff-test-cases JSON + sanity checks with example program