Initialize privateAttributes
in TargetBuilder
#9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If creating a target via TargetBuilder, and private attributes aren't specified via
TargetBuilder.PrivateAttributes
, theprivateAttributes
member never gets initialized, which becomes a problem when analytics get published here: https://github.com/drone/ff-dotnet-server-sdk/blob/main/client/api/analytics/AnalyticsPublisherService.cs#L102