[FFM-5103] changed prereq matches from value to identifer #100
Conversation
… bool flags on the UI (identifiers for variations must me true/false only)
laura135
changed the title
| @@ -546,13 +546,13 @@ func TestFeatureConfig_EvaluateWithPreReqFlags(t *testing.T) { | |||
| onBool := Variation{ | |||
| Name: stringPtr("On"), | |||
| Value: "true", | |||
| Identifier: "on", | |||
There was a problem hiding this comment.
Was this change essential for the test to pass?
If so it makes me think we still have an issue somewhere where we are comparing value to identifier.
There was a problem hiding this comment.
yep, it's related to this https://harness.atlassian.net/browse/FFM-5116
|
Not so much an issue with comparing for this one - it's more on how we create boolean flags for the sdk versus the UI. The UI locks it down so that identifiers for variation can only be true or false but creating via api doesn't. Before the change this test would have compared Values which were true/false. After the change this test compares with identifiers which were on/off before I change them) so I think it's running up against whatever rule we have that means we can only have the true/false id for variations when creating a flag on the UI |
|
But in looking I did see that we had another place where we compared values to identifiers for nested prereqs on line 568 so have updated that too |
What:
Updates prerequisite checks so that they compare by flag identifier and not value
Updates feature_test.go so that the boolean flag created for a prerequisite test is inline with UI Rules - variation identifiers should be true/false only.
Why:
Was sending back wrong variation when flag identifier and value were not identical for a prerequisite flag
Was sending back wrong variation when prereq bool flag had variation identifiers that weren't true/false